restructuring for rental requests. started double blind reviews

frontend/src/pages/ItemDetail.tsx

@@ -110,15 +110,80 @@ const ItemDetail: React.FC = () => {
     setTotalCost(cost);
   };
 
-  const generateTimeOptions = () => {
+  const generateTimeOptions = (item: Item | null, selectedDate: string) => {
     const options = [];
+    let availableAfter = "00:00";
+    let availableBefore = "23:59";
+
+    console.log('generateTimeOptions called with:', { 
+      itemId: item?.id, 
+      selectedDate, 
+      hasItem: !!item 
+    });
+
+    // Determine time constraints only if we have both item and a valid selected date
+    if (item && selectedDate && selectedDate.trim() !== "") {
+      const date = new Date(selectedDate);
+      const dayName = date.toLocaleDateString('en-US', { weekday: 'long' }).toLowerCase() as
+        'sunday' | 'monday' | 'tuesday' | 'wednesday' | 'thursday' | 'friday' | 'saturday';
+
+      console.log('Date analysis:', { 
+        selectedDate, 
+        dayName, 
+        specifyTimesPerDay: item.specifyTimesPerDay,
+        hasWeeklyTimes: !!item.weeklyTimes,
+        globalAvailableAfter: item.availableAfter,
+        globalAvailableBefore: item.availableBefore
+      });
+
+      // Use day-specific times if available
+      if (item.specifyTimesPerDay && item.weeklyTimes && item.weeklyTimes[dayName]) {
+        const dayTimes = item.weeklyTimes[dayName];
+        availableAfter = dayTimes.availableAfter;
+        availableBefore = dayTimes.availableBefore;
+        console.log('Using day-specific times:', { availableAfter, availableBefore });
+      }
+      // Otherwise use global times
+      else if (item.availableAfter && item.availableBefore) {
+        availableAfter = item.availableAfter;
+        availableBefore = item.availableBefore;
+        console.log('Using global times:', { availableAfter, availableBefore });
+      } else {
+        console.log('No time constraints found, using default 24-hour availability');
+      }
+    } else {
+      console.log('Missing item or selectedDate, using default 24-hour availability');
+    }
+
     for (let hour = 0; hour < 24; hour++) {
       const time24 = `${hour.toString().padStart(2, "0")}:00`;
-      const hour12 = hour === 0 ? 12 : hour > 12 ? hour - 12 : hour;
-      const period = hour < 12 ? "AM" : "PM";
-      const time12 = `${hour12}:00 ${period}`;
-      options.push({ value: time24, label: time12 });
+      
+      // Ensure consistent format for comparison (normalize to HH:MM)
+      const normalizedAvailableAfter = availableAfter.length === 5 ? availableAfter : availableAfter + ":00";
+      const normalizedAvailableBefore = availableBefore.length === 5 ? availableBefore : availableBefore + ":00";
+      
+      // Check if this time is within the available range
+      if (time24 >= normalizedAvailableAfter && time24 <= normalizedAvailableBefore) {
+        const hour12 = hour === 0 ? 12 : hour > 12 ? hour - 12 : hour;
+        const period = hour < 12 ? "AM" : "PM";
+        const time12 = `${hour12}:00 ${period}`;
+        options.push({ value: time24, label: time12 });
+      }
     }
+    
+    console.log('Time filtering results:', { 
+      availableAfter, 
+      availableBefore, 
+      optionsGenerated: options.length,
+      firstFewOptions: options.slice(0, 3)
+    });
+    
+    // If no options are available, return at least one option to prevent empty dropdown
+    if (options.length === 0) {
+      console.log('No valid time options found, showing Not Available');
+      options.push({ value: "00:00", label: "Not Available" });
+    }
+    
     return options;
   };
 
@@ -126,6 +191,34 @@ const ItemDetail: React.FC = () => {
     calculateTotalCost();
   }, [rentalDates, item]);
 
+  // Validate and adjust selected times based on item availability
+  useEffect(() => {
+    if (!item) return;
+
+    const validateAndAdjustTime = (date: string, currentTime: string) => {
+      if (!date) return currentTime;
+      
+      const availableOptions = generateTimeOptions(item, date);
+      if (availableOptions.length === 0) return currentTime;
+      
+      // If current time is not in available options, use the first available time
+      const isCurrentTimeValid = availableOptions.some(option => option.value === currentTime);
+      return isCurrentTimeValid ? currentTime : availableOptions[0].value;
+    };
+
+    const adjustedStartTime = validateAndAdjustTime(rentalDates.startDate, rentalDates.startTime);
+    const adjustedEndTime = validateAndAdjustTime(rentalDates.endDate || rentalDates.startDate, rentalDates.endTime);
+
+    // Update state if times have changed
+    if (adjustedStartTime !== rentalDates.startTime || adjustedEndTime !== rentalDates.endTime) {
+      setRentalDates(prev => ({
+        ...prev,
+        startTime: adjustedStartTime,
+        endTime: adjustedEndTime
+      }));
+    }
+  }, [item, rentalDates.startDate, rentalDates.endDate]);
+
   if (loading) {
     return (
       <div className="container mt-5">
@@ -392,8 +485,9 @@ const ItemDetail: React.FC = () => {
                                 handleDateTimeChange("startTime", e.target.value)
                               }
                               style={{ flex: '1 1 50%' }}
+                              disabled={!!(rentalDates.startDate && generateTimeOptions(item, rentalDates.startDate).every(opt => opt.label === "Not Available"))}
                             >
-                              {generateTimeOptions().map((option) => (
+                              {generateTimeOptions(item, rentalDates.startDate).map((option) => (
                                 <option key={option.value} value={option.value}>
                                   {option.label}
                                 </option>
@@ -425,8 +519,9 @@ const ItemDetail: React.FC = () => {
                                 handleDateTimeChange("endTime", e.target.value)
                               }
                               style={{ flex: '1 1 50%' }}
+                              disabled={!!((rentalDates.endDate || rentalDates.startDate) && generateTimeOptions(item, rentalDates.endDate || rentalDates.startDate).every(opt => opt.label === "Not Available"))}
                             >
-                              {generateTimeOptions().map((option) => (
+                              {generateTimeOptions(item, rentalDates.endDate || rentalDates.startDate).map((option) => (
                                 <option key={option.value} value={option.value}>
                                   {option.label}
                                 </option>