backend unit test coverage to 80%
This commit is contained in:
jackiettran
@@ -46,7 +46,16 @@ const {
|
||||
validateLogin,
|
||||
validateGoogleAuth,
|
||||
validateProfileUpdate,
|
||||
validatePasswordChange
|
||||
validatePasswordChange,
|
||||
validateForgotPassword,
|
||||
validateResetPassword,
|
||||
validateVerifyResetToken,
|
||||
validateFeedback,
|
||||
validateCoordinatesQuery,
|
||||
validateCoordinatesBody,
|
||||
validateTotpCode,
|
||||
validateEmailOtp,
|
||||
validateRecoveryCode
|
||||
} = require('../../../middleware/validation');
|
||||
|
||||
describe('Validation Middleware', () => {
|
||||
@@ -2066,4 +2075,392 @@ describe('Validation Middleware', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('Two-Factor Authentication Validation', () => {
|
||||
describe('validateTotpCode', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateTotpCode)).toBe(true);
|
||||
expect(validateTotpCode.length).toBeGreaterThan(1);
|
||||
expect(validateTotpCode[validateTotpCode.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate 6-digit numeric format', () => {
|
||||
const validCodes = ['123456', '000000', '999999', '012345'];
|
||||
const invalidCodes = ['12345', '1234567', 'abcdef', '12345a', '12 345', ''];
|
||||
const totpRegex = /^\d{6}$/;
|
||||
|
||||
validCodes.forEach(code => {
|
||||
expect(totpRegex.test(code)).toBe(true);
|
||||
});
|
||||
|
||||
invalidCodes.forEach(code => {
|
||||
expect(totpRegex.test(code)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
it('should have at least 2 middleware functions', () => {
|
||||
expect(validateTotpCode.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('validateEmailOtp', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateEmailOtp)).toBe(true);
|
||||
expect(validateEmailOtp.length).toBeGreaterThan(1);
|
||||
expect(validateEmailOtp[validateEmailOtp.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate 6-digit numeric format', () => {
|
||||
const validCodes = ['123456', '000000', '999999', '654321'];
|
||||
const invalidCodes = ['12345', '1234567', 'abcdef', '12345a', '', ' '];
|
||||
const otpRegex = /^\d{6}$/;
|
||||
|
||||
validCodes.forEach(code => {
|
||||
expect(otpRegex.test(code)).toBe(true);
|
||||
});
|
||||
|
||||
invalidCodes.forEach(code => {
|
||||
expect(otpRegex.test(code)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
it('should have at least 2 middleware functions', () => {
|
||||
expect(validateEmailOtp.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
|
||||
describe('validateRecoveryCode', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateRecoveryCode)).toBe(true);
|
||||
expect(validateRecoveryCode.length).toBeGreaterThan(1);
|
||||
expect(validateRecoveryCode[validateRecoveryCode.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate XXXX-XXXX format', () => {
|
||||
const validCodes = ['ABCD-1234', 'abcd-efgh', '1234-5678', 'A1B2-C3D4', 'aaaa-bbbb'];
|
||||
const invalidCodes = ['ABCD1234', 'ABCD-12345', 'ABC-1234', 'ABCD-123', '', 'ABCD--1234', 'ABCD_1234'];
|
||||
const recoveryRegex = /^[A-Za-z0-9]{4}-[A-Za-z0-9]{4}$/i;
|
||||
|
||||
validCodes.forEach(code => {
|
||||
expect(recoveryRegex.test(code)).toBe(true);
|
||||
});
|
||||
|
||||
invalidCodes.forEach(code => {
|
||||
expect(recoveryRegex.test(code)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
it('should have at least 2 middleware functions', () => {
|
||||
expect(validateRecoveryCode.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Password Reset Validation', () => {
|
||||
describe('validateForgotPassword', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateForgotPassword)).toBe(true);
|
||||
expect(validateForgotPassword.length).toBeGreaterThan(1);
|
||||
expect(validateForgotPassword[validateForgotPassword.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate email format', () => {
|
||||
const validEmails = ['user@example.com', 'test.user@domain.co.uk', 'email@test.org'];
|
||||
const invalidEmails = ['invalid-email', '@domain.com', 'user@', 'user.domain.com'];
|
||||
const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
|
||||
|
||||
validEmails.forEach(email => {
|
||||
expect(emailRegex.test(email)).toBe(true);
|
||||
});
|
||||
|
||||
invalidEmails.forEach(email => {
|
||||
expect(emailRegex.test(email)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
it('should enforce email length limits', () => {
|
||||
const longEmail = 'a'.repeat(250) + '@example.com';
|
||||
expect(longEmail.length).toBeGreaterThan(255);
|
||||
|
||||
const validEmail = 'user@example.com';
|
||||
expect(validEmail.length).toBeLessThanOrEqual(255);
|
||||
});
|
||||
});
|
||||
|
||||
describe('validateResetPassword', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateResetPassword)).toBe(true);
|
||||
expect(validateResetPassword.length).toBeGreaterThan(1);
|
||||
expect(validateResetPassword[validateResetPassword.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate 64-character token format', () => {
|
||||
const valid64CharToken = 'a'.repeat(64);
|
||||
const shortToken = 'a'.repeat(63);
|
||||
const longToken = 'a'.repeat(65);
|
||||
|
||||
expect(valid64CharToken.length).toBe(64);
|
||||
expect(shortToken.length).toBe(63);
|
||||
expect(longToken.length).toBe(65);
|
||||
});
|
||||
|
||||
it('should validate password strength requirements', () => {
|
||||
const passwordRegex = /^(?=.*\d)(?=.*[a-z])(?=.*[A-Z])(?=.*[a-zA-Z])(?=.*[-@$!%*?&#^]).{8,}$/;
|
||||
|
||||
const strongPasswords = ['Password123!', 'MyStr0ng@Pass', 'Secure1#Test'];
|
||||
const weakPasswords = ['password', 'PASSWORD123', 'Password', '12345678'];
|
||||
|
||||
strongPasswords.forEach(password => {
|
||||
expect(passwordRegex.test(password)).toBe(true);
|
||||
});
|
||||
|
||||
weakPasswords.forEach(password => {
|
||||
expect(passwordRegex.test(password)).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
it('should have multiple middleware functions for token and password', () => {
|
||||
expect(validateResetPassword.length).toBeGreaterThanOrEqual(3);
|
||||
});
|
||||
});
|
||||
|
||||
describe('validateVerifyResetToken', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateVerifyResetToken)).toBe(true);
|
||||
expect(validateVerifyResetToken.length).toBeGreaterThan(1);
|
||||
expect(validateVerifyResetToken[validateVerifyResetToken.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate 64-character token format', () => {
|
||||
const valid64CharToken = 'abcdef1234567890'.repeat(4);
|
||||
expect(valid64CharToken.length).toBe(64);
|
||||
|
||||
const shortToken = 'abc123'.repeat(10);
|
||||
expect(shortToken.length).toBe(60);
|
||||
|
||||
const longToken = 'a'.repeat(65);
|
||||
expect(longToken.length).toBe(65);
|
||||
});
|
||||
|
||||
it('should have at least 2 middleware functions', () => {
|
||||
expect(validateVerifyResetToken.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Feedback Validation', () => {
|
||||
describe('validateFeedback', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateFeedback)).toBe(true);
|
||||
expect(validateFeedback.length).toBeGreaterThan(1);
|
||||
expect(validateFeedback[validateFeedback.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate text length (5-5000 chars)', () => {
|
||||
const tooShort = 'abcd'; // 4 chars
|
||||
const minValid = 'abcde'; // 5 chars
|
||||
const maxValid = 'a'.repeat(5000);
|
||||
const tooLong = 'a'.repeat(5001);
|
||||
|
||||
expect(tooShort.length).toBe(4);
|
||||
expect(minValid.length).toBe(5);
|
||||
expect(maxValid.length).toBe(5000);
|
||||
expect(tooLong.length).toBe(5001);
|
||||
|
||||
// Validate boundaries
|
||||
expect(tooShort.length).toBeLessThan(5);
|
||||
expect(minValid.length).toBeGreaterThanOrEqual(5);
|
||||
expect(maxValid.length).toBeLessThanOrEqual(5000);
|
||||
expect(tooLong.length).toBeGreaterThan(5000);
|
||||
});
|
||||
|
||||
it('should have at least 2 middleware functions', () => {
|
||||
expect(validateFeedback.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
|
||||
it('should include optional URL validation', () => {
|
||||
// The feedback validation should include url field as optional
|
||||
expect(validateFeedback.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Coordinates Validation', () => {
|
||||
describe('validateCoordinatesQuery', () => {
|
||||
it('should be an array ending with handleValidationErrors', () => {
|
||||
expect(Array.isArray(validateCoordinatesQuery)).toBe(true);
|
||||
expect(validateCoordinatesQuery.length).toBeGreaterThan(1);
|
||||
expect(validateCoordinatesQuery[validateCoordinatesQuery.length - 1]).toBe(handleValidationErrors);
|
||||
});
|
||||
|
||||
it('should validate latitude range (-90 to 90)', () => {
|
||||
const validLatitudes = [0, 45, -45, 90, -90, 37.7749];
|
||||
const invalidLatitudes = [91, -91, 180, -180, 1000];
|
||||
|
||||
validLatitudes.forEach(lat => {
|
||||
expect(lat).toBeGreaterThanOrEqual(-90);
|
||||
expect(lat).toBeLessThanOrEqual(90);
|
||||
});
|
||||
|
||||
invalidLatitudes.forEach(lat => {
|
||||
expect(lat < -90 || lat > 90).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should validate longitude range (-180 to 180)', () => {
|
||||
const validLongitudes = [0, 90, -90, 180, -180, -122.4194];
|
||||
const invalidLongitudes = [181, -181, 360, -360];
|
||||
|
||||
validLongitudes.forEach(lng => {
|
||||
expect(lng).toBeGreaterThanOrEqual(-180);
|
||||
expect(lng).toBeLessThanOrEqual(180);
|
||||
});
|
||||
|
||||
invalidLongitudes.forEach(lng => {
|
||||
expect(lng < -180 || lng > 180).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should validate radius range (0.1 to 100)', () => {
|
||||
const validRadii = [0.1, 1, 50, 100, 0.5, 99.9];
|
||||
const invalidRadii = [0, 0.05, 100.1, 200, -1];
|
||||
|
||||
validRadii.forEach(radius => {
|
||||
expect(radius).toBeGreaterThanOrEqual(0.1);
|
||||
expect(radius).toBeLessThanOrEqual(100);
|
||||
});
|
||||
|
||||
invalidRadii.forEach(radius => {
|
||||
expect(radius < 0.1 || radius > 100).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should have middleware for lat, lng, and radius', () => {
|
||||
expect(validateCoordinatesQuery.length).toBeGreaterThanOrEqual(4);
|
||||
});
|
||||
});
|
||||
|
||||
describe('validateCoordinatesBody', () => {
|
||||
it('should be an array with validation middleware', () => {
|
||||
expect(Array.isArray(validateCoordinatesBody)).toBe(true);
|
||||
expect(validateCoordinatesBody.length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it('should validate body latitude range (-90 to 90)', () => {
|
||||
const validLatitudes = [0, 45.5, -89.99, 90, -90];
|
||||
const invalidLatitudes = [90.1, -90.1, 100, -100];
|
||||
|
||||
validLatitudes.forEach(lat => {
|
||||
expect(lat).toBeGreaterThanOrEqual(-90);
|
||||
expect(lat).toBeLessThanOrEqual(90);
|
||||
});
|
||||
|
||||
invalidLatitudes.forEach(lat => {
|
||||
expect(lat < -90 || lat > 90).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should validate body longitude range (-180 to 180)', () => {
|
||||
const validLongitudes = [0, 179.99, -179.99, 180, -180];
|
||||
const invalidLongitudes = [180.1, -180.1, 200, -200];
|
||||
|
||||
validLongitudes.forEach(lng => {
|
||||
expect(lng).toBeGreaterThanOrEqual(-180);
|
||||
expect(lng).toBeLessThanOrEqual(180);
|
||||
});
|
||||
|
||||
invalidLongitudes.forEach(lng => {
|
||||
expect(lng < -180 || lng > 180).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it('should have middleware for latitude and longitude', () => {
|
||||
expect(validateCoordinatesBody.length).toBeGreaterThanOrEqual(2);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('Module Exports Completeness', () => {
|
||||
it('should export all validators from the module', () => {
|
||||
const validationModule = require('../../../middleware/validation');
|
||||
|
||||
// Core middleware
|
||||
expect(validationModule).toHaveProperty('sanitizeInput');
|
||||
expect(validationModule).toHaveProperty('handleValidationErrors');
|
||||
|
||||
// Auth validators
|
||||
expect(validationModule).toHaveProperty('validateRegistration');
|
||||
expect(validationModule).toHaveProperty('validateLogin');
|
||||
expect(validationModule).toHaveProperty('validateGoogleAuth');
|
||||
|
||||
// Profile validators
|
||||
expect(validationModule).toHaveProperty('validateProfileUpdate');
|
||||
expect(validationModule).toHaveProperty('validatePasswordChange');
|
||||
|
||||
// Password reset validators
|
||||
expect(validationModule).toHaveProperty('validateForgotPassword');
|
||||
expect(validationModule).toHaveProperty('validateResetPassword');
|
||||
expect(validationModule).toHaveProperty('validateVerifyResetToken');
|
||||
|
||||
// Feedback validator
|
||||
expect(validationModule).toHaveProperty('validateFeedback');
|
||||
|
||||
// Coordinate validators
|
||||
expect(validationModule).toHaveProperty('validateCoordinatesQuery');
|
||||
expect(validationModule).toHaveProperty('validateCoordinatesBody');
|
||||
|
||||
// 2FA validators
|
||||
expect(validationModule).toHaveProperty('validateTotpCode');
|
||||
expect(validationModule).toHaveProperty('validateEmailOtp');
|
||||
expect(validationModule).toHaveProperty('validateRecoveryCode');
|
||||
});
|
||||
|
||||
it('should export functions and arrays with correct types', () => {
|
||||
const validationModule = require('../../../middleware/validation');
|
||||
|
||||
// Functions
|
||||
expect(typeof validationModule.sanitizeInput).toBe('function');
|
||||
expect(typeof validationModule.handleValidationErrors).toBe('function');
|
||||
|
||||
// Arrays (validation chains)
|
||||
expect(Array.isArray(validationModule.validateRegistration)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateLogin)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateGoogleAuth)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateProfileUpdate)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validatePasswordChange)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateForgotPassword)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateResetPassword)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateVerifyResetToken)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateFeedback)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateCoordinatesQuery)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateCoordinatesBody)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateTotpCode)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateEmailOtp)).toBe(true);
|
||||
expect(Array.isArray(validationModule.validateRecoveryCode)).toBe(true);
|
||||
});
|
||||
|
||||
it('should have all validation arrays end with handleValidationErrors', () => {
|
||||
const validationModule = require('../../../middleware/validation');
|
||||
const validatorsWithHandler = [
|
||||
'validateRegistration',
|
||||
'validateLogin',
|
||||
'validateGoogleAuth',
|
||||
'validateProfileUpdate',
|
||||
'validatePasswordChange',
|
||||
'validateForgotPassword',
|
||||
'validateResetPassword',
|
||||
'validateVerifyResetToken',
|
||||
'validateFeedback',
|
||||
'validateCoordinatesQuery',
|
||||
'validateTotpCode',
|
||||
'validateEmailOtp',
|
||||
'validateRecoveryCode'
|
||||
];
|
||||
|
||||
validatorsWithHandler.forEach(validatorName => {
|
||||
const validator = validationModule[validatorName];
|
||||
expect(validator[validator.length - 1]).toBe(validationModule.handleValidationErrors);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
});
|
||||
Reference in New Issue
Block a user